Skip to content

Make error message nicer when bors service panics in tests #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Make error message nicer when bors service panics in tests #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/tests/mocks/bors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,11 @@ impl BorsBuilder {

match result {
Ok(res) => match res {
Ok(_) => gh_state.expect("Bors service has failed"),
Ok(_) => gh_state
.context("Bors service has failed")
// This makes the error nicer
.map_err(|e| e.to_string())
.unwrap(),
Err(error) => {
panic!(
"Test has failed: {error:?}\n\nBors service error: {:?}",
Expand Down
Loading