refactor: inline GlobalContext::get_path #16125
Draft
+111
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Oct 16, 2025
| pub fn resolve_root(flag: Option<&str>, gctx: &GlobalContext) -> CargoResult<Filesystem> { | ||
| let config_root = gctx.get_path("install.root")?; | ||
| let config_root = gctx | ||
| .get::<OptValue<ConfigRelativePath>>("install.root") |
There was a problem hiding this comment.
Just FYI, this can be Option<ConfigRelativePath>>. We don't use the definition here, so this can be simplified.
0xPoe
force-pushed
the
poe-patch-install.root
branch
from
02a2a2d to
f51943b
Compare
0xPoe
force-pushed
the
poe-patch-install.root
branch
2 times, most recently
from
daf3b81 to
9e4b6b4
Compare
0xPoe
force-pushed
the
poe-patch-install.root
branch
from
ce3da9f to
79e2090
Compare
0xPoe
force-pushed
the
poe-patch-install.root
branch
from
799ae1f to
c8a79f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #16023
Improve the warning message for realtive install location.
How to test and review this PR?
Please check the unit test.
r?@ghost