Warn when installing with a non-default toolchain#16131
Warn when installing with a non-default toolchain#16131smoelius wants to merge 4 commits intorust-lang:masterfrom
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
2157847 to
9006944
Compare
weihanglo
left a comment
There was a problem hiding this comment.
EDIT: The force push was to make Clippy happy.
Feel free to force-push and re-organize your commits during the iterations.
5f2fbb4 to
c64e01a
Compare
This comment has been minimized.
This comment has been minimized.
c64e01a to
f0f222f
Compare
|
Just FYI, I know it looks like only some of the comments have been addressed. I am still hoping to get feedback on #16131 (comment) and #16131 (comment). |
f75ccb8 to
a386ddd
Compare
|
I resolved comments that I thought I implemented uncontroversially. I hope that was okay. EDIT: I also hid a few of my own comments that were old. |
|
Please clean up your commits for how they should be reviewed and merged, rather than for how it was developed. |
2e97d39 to
79a32f6
Compare
Thought of this when reviewing new cases for `std::env` in rust-lang#16131.
Thought of this when reviewing new cases for `std::env` in rust-lang#16131.
### What does this PR try to resolve? Thought of this when reviewing new cases for `std::env` in #16131. ### How to test and review this PR?
This is the first of several commits to implement a fix for rust-lang#11036. The changes fetch the `RUSTUP_TOOLCHAIN_SOURCE` environment variable set by Rustup, and warn if it is anything other than "default" or "cli".
79a32f6 to
a106b1d
Compare
|
I need to fix the commits. I will do that within the next few hours. |
a106b1d to
bd62811
Compare
|
The commits should be fixed now. |
bd62811 to
78f7c63
Compare
|
Thanks for your patience through the rounds of feedback! This is looking great! |
78f7c63 to
5aee235
Compare
5aee235 to
815ceb1
Compare
815ceb1 to
8f464a5
Compare
|
@rami3l when would we be good for merging support for this? |
|
@epage I'd say after v1.29.0 has been properly released and stabilized for a bit, but that will be pretty close from here. Judging from the current progress, I'd say the release could happen next week or another week after that, unless new blocking PRs resurface by then. I'm planning that out depending on my availabilities during the night. Please stay tuned and many thanks in advance for your comprehension! |
This PR implements the cargo changes for #11036. The rustup changes were implemented in rust-lang/rustup#4518.
The PR is currently organized as four commits:
RUSTUP_TOOLCHAIN_SOURCE. This change is not strictly necessary, but it improves the rustup tests' fidelity.pkgfunction to a location where the next commit can use it.cargo installis invoked with a non-default toolchain, as indicated byRUSTUP_TOOLCHAIN_SOURCE.In the third commit, two significant changes were made to
simulated_rustup_environment:RUSTUP_TOOLCHAIN_SOURCE) before calling the proxied tool.The PR is currently marked as draft because rust-lang/rustup#4518 has not yet been released. Technically, this PR could be merged before then. But testing it with a fixed rustup would seem to make sense.
Nits are welcome.
cc: @epage