Remove no-asm gating when there is no alternative implementation
#994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, maybe it is a good thing to provide a way to require the generic implementations when they exist, so there is a way to keep testing them on platforms that have asm versions. We still don't need this for functions that only have an assembly implementation. I'll update. |
tgross35
changed the title
no-asm featureno-asm gating when there is no alternative implementation
Amanieu
approved these changes
Jul 27, 2025
Assembly-related configuration was added in 1621c6d ("Use `specialized-div-rem` 1.0.0 for division algorithms") to account for Cranelift not yet supporting assembly. This hasn't been relevant for a while, so we no longer need to gate `asm!` behind this configuration. Thus, remove `cfg(not(feature = "no-asm"))` in places where there is no generic fallback. There are other cases, however, where setting the `no-asm` configuration enables testing of generic version of builtins when there are platform- specific implementations available; these cases are left unchanged. This could be improved in the future by exposing both versions for testing rather than using a configuration and running the entire testsuite twice. This is the compiler-builtins portion of rust-lang/rust#144471.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly-related configuration was added in 1621c6d ("Use
specialized-div-rem1.0.0 for division algorithms") to account forCranelift not yet supporting assembly. This hasn't been relevant for a
while, so we no longer need to gate
asm!behind this configuration.Thus, remove
cfg(not(feature = "no-asm"))in places where there is nogeneric fallback.
There are other cases, however, where setting the
no-asmconfigurationenables testing of generic version of builtins when there are platform-
specific implementations available; these cases are left unchanged. This
could be improved in the future by exposing both versions for testing
rather than using a configuration and running the entire testsuite
twice.
This is the compiler-builtins portion of
rust-lang/rust#144471.