always use stable Rust to build josh #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a huge fan of having josh installed automatically -- that's a global change to my system that IMO a tool shouldn't do without first asking me, and it makes it impossible to use the tool with a local, experimental version of josh (this
cargo installwill always downgrade it back to the released version). However, I am even more not a fan of having that build done with whatever random toolchain happens to be active when I invoke josh-sync. At the very least, let's make sure we use a stable version of Rust, not some nightly snapshot.