Skip to content

Conversation

alexcrichton
Copy link
Member

This is similar to #3869 except that it adds tests for wasm32-wasip2 in addition to wasm32-wasip1. This is intended to eventually empower definitions from rust-lang/rust#129638 to move into this repository.

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Aug 28, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks for the change!

@tgross35
Copy link
Contributor

Ah could you squash real quick? Keep forgetting we don't have squash&merge on this repo

This is similar to rust-lang#3869 except that it adds tests for `wasm32-wasip2`
in addition to `wasm32-wasip1`. This is intended to eventually empower
definitions from rust-lang/rust#129638 to move into this repository.
@alexcrichton
Copy link
Member Author

Sure thing 👍

@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge August 28, 2024 20:41
@tgross35 tgross35 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into rust-lang:main with commit cce4997 Aug 28, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
This is similar to rust-lang#3869 except that it adds tests for `wasm32-wasip2`
in addition to `wasm32-wasip1`. This is intended to eventually empower
definitions from rust-lang/rust#129638 to move into this repository.

(backport <rust-lang#3870>)
(cherry picked from commit 15f8c44)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
This is similar to rust-lang#3869 except that it adds tests for `wasm32-wasip2`
in addition to `wasm32-wasip1`. This is intended to eventually empower
definitions from rust-lang/rust#129638 to move into this repository.

(backport <rust-lang#3870>)
(cherry picked from commit 15f8c44)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants