ctest: add support for skipping more items and prepare for ctest-test port #4555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Jul 17, 2025
mbyx
force-pushed
the
ctest-generator-frontend
branch
2 times, most recently
from
044b46b to
e304174
Compare
tgross35
reviewed
Jul 17, 2025
ctest-next/src/translator.rs
Outdated
| @@ -26,24 +27,29 @@ impl TranslationError { | |||
| Self { | |||
| kind, | |||
| source: source.to_string(), | |||
| span, | |||
| span: format!( | |||
| "line {}, column {}, in {}", | |||
There was a problem hiding this comment.
It's kind of standard to do foo.rs:10:20, some terminals will hyperlink that for you
"{fname}:{line}:{col}",
// FIXME(ctest): ...
fname = "<unknown file>"
line = span.start().line,
col = span.start().column,
mbyx
force-pushed
the
ctest-generator-frontend
branch
from
e304174 to
575c83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds better support for skipping unions, fields, and tests for field types. Additionally makes needed changes to other parts of
ctest-nextso that the port PRs forctest-testandlibc-testdon't have too many changes toctest-next.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI