Skip to content

Fix error message for config.get deserialization error #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
Merged

Fix error message for config.get deserialization error #2902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d9fdd
Add a test for config.get deserialization error
ehuss Oct 25, 2025
adcbd11
Fix error message for config.get deserialization error
ehuss Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion crates/mdbook-core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ impl Config {
value
.clone()
.try_into()
.with_context(|| "Failed to deserialize `{name}`")
.with_context(|| format!("Failed to deserialize `{name}`"))
})
.transpose()
}
Expand Down Expand Up @@ -1147,4 +1147,18 @@ mod tests {
assert_eq!(json!(TextDirection::RightToLeft), json!("rtl"));
assert_eq!(json!(TextDirection::LeftToRight), json!("ltr"));
}

#[test]
fn get_deserialize_error() {
let src = r#"
[preprocessor.foo]
x = 123
"#;
let cfg = Config::from_str(src).unwrap();
let err = cfg.get::<String>("preprocessor.foo.x").unwrap_err();
assert_eq!(
err.to_string(),
"Failed to deserialize `preprocessor.foo.x`"
);
}
}