- 
                Notifications
    You must be signed in to change notification settings 
- Fork 399
          Implement chmod and fchmod for Unix targets
          #4214
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add tests for the new functions
| 
 I've tried. Those tests would rely on  | 
| Maybe the shim we use to read permission is unfinished and doesn't work at all even though it could work on Unix? | 
| Yes, according to  | 
9b65328    to
    b9a6736      
    Compare
  
    | I think should fix the read functions before making the write functions do anything | 
| Hi @el-ev, this PR appears to be inactive for quite a while, just checking if you're able to continue, or if you'd like any help to move it forward? | 
| I will just mark this as  Feel free to ask more questions or mark this as ready (after resolving feedback) by writing  @rustbot author | 
Closes #4202
I was unable to write a test because
FileMetadataonly returns mode0o100000for the files, no permission information is provided.