Merged
Conversation
celinval
reviewed
Aug 20, 2025
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Can we merge this PR now if we comment out the rustc_public dependency from demo/Cargo.toml and add an extern crate rustc_public for now?
Member
Author
|
It works, but I think #104 should be good to merge as I've rebased it and things are in the rustc_public folder now. Btw my commits are ready for review, so after that PR is merged I'll open a series of prs. maybe we could wait for it then? |
Member
Author
|
or is there any blocker on #104? If so, it makes sense to do that for now |
Contributor
|
I do think there might be a blocker. Let me post it there |
Member
Author
|
okay done |
celinval
approved these changes
Aug 30, 2025
makai410
added a commit
to makai410/rustc_public
that referenced
this pull request
Dec 1, 2025
Update demo to use new crate name `rustc_pulbic`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #104