Skip to content

Fix missing RestPat for convert_named_struct_to_tuple_struct #20872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing RestPat for convert_named_struct_to_tuple_struct #20872

wants to merge 1 commit into from

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Oct 20, 2025 •
edited by rustbot
Loading

Fixes #20847

Example

struct Inner;
struct A$0 { inner: Inner }
fn foo(A { .. }: A) {}

Before this PR:

struct Inner;
struct A(Inner);
fn foo(A(): A) {}

After this PR:

struct Inner;
struct A(Inner);
fn foo(A(..): A) {}

@A4-Tacks
Fix missing RestPat for convert_named_struct_to_tuple_struct
416ff1c 
Example
---
```rust
struct Inner;
struct A$0 { inner: Inner }
fn foo(A { .. }: A) {}
```

**Before this PR**:

```rust
struct Inner;
struct A(Inner);
fn foo(A(): A) {}
```

**After this PR**:

```rust
struct Inner;
struct A(Inner);
fn foo(A(..): A) {}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Convert to tuple struct" incorrectly erases .. patterns

2 participants

@A4-Tacks @rustbot