-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Warn about types not meeting MSRV #15296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lintcheck changes for 11bfeca
This comment will be updated if you push new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Yeah, I'll investigate the number of new hits! |
Reminder, once the PR becomes ready for a review, use |
|
The main issue here is that if a MSRV-incompatible type is aliased, or is imported, then every use of it will trigger the lint as it resolves to the same I'll make the |
Looks like we didn't need to do anything with |
921e9dc
to
4fcd3d2
Compare
Done. |
For example, the `Duration` type from the standard library was only introduced in Rust 1.3.0.
4fcd3d2
to
11bfeca
Compare
I'll rebase #15297 on top. |
This makes `const` contexts use the `const`-stability version information instead of the regular stability one, as `const`-stability may happen much later than stability in non-`const` contexts. ~~It includes the content of PR #15296 as its first commit. I separated them because this one is more complex, and #15296 may be merged more rapidly.~~ changelog: [`incompatible_msrv`]: check the right MSRV when in a `const` context r? Jarcho @rustbot label +C-bug +I-false-negative
For example, the
Duration
type from the standard library was only introduced in Rust 1.3.0.changelog: [
incompatible_msrv
]: recognize types exceeding MSRV as wellr? Jarcho @rustbot label +C-bug +I-false-negative