Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 21, 2025

Reduces boilerplate a bit

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a force-pushed the as_some_expr_and_pat branch 2 times, most recently from 5addeba to 1e3f332 Compare October 21, 2025 19:20
@ada4a
Copy link
Contributor Author

ada4a commented Oct 21, 2025

This needs to depend on #15929 for a somewhat annoying reason: the spans in unnecessary_filter_map are completely borked, and this PR happens to change the span from one broken version to another, which ui_test complains about. Oh well.

@rustbot blocked

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 21, 2025
@ada4a ada4a force-pushed the as_some_expr_and_pat branch from 1e3f332 to 2ceb669 Compare October 21, 2025 19:30
@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the as_some_expr_and_pat branch from 2ceb669 to 7024bec Compare October 21, 2025 22:25
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the as_some_expr_and_pat branch from 7024bec to 605cc87 Compare October 27, 2025 15:57
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants