Skip to content

[WIP] Figure out testing strategy for pr 108996 #109131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WIP] Figure out testing strategy for pr 108996 #109131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6536df1
the sketch of a test -- but does not yet work to expose bug on my mac…
pnkfelix Mar 10, 2023
98ae92a
try to fix how Makefile is selected solely for wasm32-unknown-unknown…
pnkfelix Mar 14, 2023
238bf32
DO NOT CHECK IN. temporarily adding wasm32 to try build set to see if…
pnkfelix Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ jobs:
tidy: false
os: ubuntu-20.04-xl
env: {}
- name: wasm32
os: ubuntu-20.04-xl
env: {}
timeout-minutes: 600
runs-on: "${{ matrix.os }}"
steps:
Expand Down
3 changes: 3 additions & 0 deletions src/ci/github-actions/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ jobs:
<<: *job-linux-xl
tidy: false

- name: wasm32
<<: *job-linux-xl

auto:
permissions:
actions: write # for rust-lang/simpleinfra/github-actions/cancel-outdated-builds
Expand Down
8 changes: 8 additions & 0 deletions tests/run-make/wasm-override-linker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
include ../../run-make-fulldeps/tools.mk

ifeq ($(TARGET),wasm32-unknown-unknown)
all:
$(RUSTC) foo.rs --crate-type cdylib --target wasm32-unknown-unknown -C linker=clang
else
all:
endif
1 change: 1 addition & 0 deletions tests/run-make/wasm-override-linker/foo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// empty file