Skip to content

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Mar 27, 2023

It's better to debug print DepNode instead of ErrorGuaranteed one line below :^)

fixes #109676

@rustbot
Copy link
Collaborator

rustbot commented Mar 27, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2023
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, r=me

@Noratrieb
Copy link
Member

r? Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned lcnr Mar 27, 2023
@compiler-errors
Copy link
Member Author

@bors r=nilstrieb rollup

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

📌 Commit f738b44 has been approved by nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2023
@compiler-errors
Copy link
Member Author

@bors r=Nilstrieb oops capitalization lol

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 27, 2023

📌 Commit f738b44 has been approved by Nilstrieb

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108548 (Clarify the 'use a constant in a pattern' error message)
 - rust-lang#109565 (Improve documentation for E0223)
 - rust-lang#109661 (Fix LVI test post LLVM 16 update)
 - rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`)
 - rust-lang#109669 (Update books)
 - rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`)
 - rust-lang#109682 (Add `#[inline]` to CStr trait implementations)
 - rust-lang#109685 (Make doc comment a little bit more accurate)
 - rust-lang#109687 (Document the heuristics IsTerminal uses on Windows)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fceb3d4 into rust-lang:master Mar 28, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 28, 2023
@compiler-errors compiler-errors deleted the dont-shadow-in-incremental_verify_ich_failed branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very weird behavior when printing dep nodes
5 participants