Skip to content

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented May 9, 2023

For some reason, the called function is cleanup on LLVM 17 instead of filter.

r? @Amanieu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2023
@durin42
Copy link
Contributor Author

durin42 commented May 9, 2023

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label May 9, 2023
@nbdd0121
Copy link
Member

nbdd0121 commented May 9, 2023

Oops, this is caused by #104070, my apologies. As @Amanieu said, the entire panic_cannot_unwind call is optimized away so the check for landingpad clause should simply be removed.

@Amanieu
Copy link
Member

Amanieu commented May 9, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 9, 2023

📌 Commit 9ee9165 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 9, 2023

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 9, 2023
vec-shrink-panik: update expectations to work on LLVM 17

For some reason, the called function is `cleanup` on LLVM 17 instead of `filter`.

r? `@Amanieu`
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#111392 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2023
For some reason, the called function is `cleanup` on LLVM 17 instead of
`filter`.

r? @Amanieu
@durin42
Copy link
Contributor Author

durin42 commented May 10, 2023

Updated with correct FileCheck syntax. Sorry!

@durin42
Copy link
Contributor Author

durin42 commented May 10, 2023

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2023
@Amanieu
Copy link
Member

Amanieu commented May 10, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 10, 2023

📌 Commit fbe4795 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 10, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108705 (Prevent ICE with broken borrow in closure)
 - rust-lang#111292 (Fix mishandled `--check-cfg` arguments order)
 - rust-lang#111382 (Isolate coverage FFI type layouts from their underlying LLVM C++ types)
 - rust-lang#111385 (vec-shrink-panik: update expectations to work on LLVM 17)
 - rust-lang#111389 (Add esp-idf platform-support page)
 - rust-lang#111432 (Use visit_assign to detect SSA locals.)
 - rust-lang#111448 (Use proper impl self type for alias impl in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit acae72e into rust-lang:master May 11, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 11, 2023
@durin42 durin42 deleted the vec-panik-17 branch May 11, 2023 09:59
aarongable pushed a commit to chromium/chromium that referenced this pull request May 16, 2023
Fixed in rust-lang/rust#111385

[email protected]

Change-Id: I2bda906fb46c7a00b89ecbb98a3c68c75658f1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4534378
Commit-Queue: danakj <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1144748}
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
Fixed in rust-lang/rust#111385

[email protected]

Change-Id: I2bda906fb46c7a00b89ecbb98a3c68c75658f1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4534378
Commit-Queue: danakj <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1144748}
NOKEYCHECK=True
GitOrigin-RevId: de108a3dc22b41bfb8b5dc8b28c272f3177f9543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants