Skip to content

Conversation

Bryanskiy
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2023
@Bryanskiy
Copy link
Contributor Author

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned wesleywiser Jun 30, 2023
@petrochenkov
Copy link
Contributor

r=me with #113196 (comment) addressed.
(Test for this is in #113126 (comment).)
@rustbot author
@bors delegate+

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2023
@bors
Copy link
Collaborator

bors commented Jun 30, 2023

✌️ @Bryanskiy, you can now approve this pull request!

If @petrochenkov told you to "r=me" after making some further change, please make that change, then do @bors r=@petrochenkov

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 30, 2023
@Bryanskiy
Copy link
Contributor Author

@bors r=@petrochenkov

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

📌 Commit f9a4db7 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2023
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Jul 1, 2023
Fix associated items effective visibility calculation for type privacy lints

Fixes rust-lang#113126 (comment).
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#113168 (fix(resolve): skip assertion judgment when NonModule is dummy)
 - rust-lang#113174 (Better messages for next on a iterator inside for loops)
 - rust-lang#113182 (Error when RPITITs' hidden types capture more lifetimes than their trait definitions)
 - rust-lang#113196 (Fix associated items effective visibility calculation for type privacy lints)
 - rust-lang#113226 (Fix try builds on the msvc builder)
 - rust-lang#113227 (Update cargo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bcd804b into rust-lang:master Jul 1, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants