Rollup of 5 pull requests #117881

TaKO8Ki · 2023-11-13T15:54:18Z

Successful merges:

Remove -Zkeep-hygiene-data. #117737 (Remove -Zkeep-hygiene-data.)
Small improvements in object lifetime default code #117830 (Small improvements in object lifetime default code)
Compute layout with spans for better cycle errors in coroutines #117858 (Compute layout with spans for better cycle errors in coroutines)
Remove some unused stuff from rustc_index #117863 (Remove some unused stuff from rustc_index)
Cranelift isn't available on non-nightly channels #117872 (Cranelift isn't available on non-nightly channels)

r? @ghost
@rustbot modify labels: rollup

@petrochenkov

It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. @petrochenkov says removing this part (and it's only part) of the hygiene data is dubious. It doesn't seem that big, so let's just keep it around.

I found those while trying to understand how the code works.

Only the impl for `u32` is used. These can be reinstated easily if needed in the future.

… r=petrochenkov Remove `-Zkeep-hygiene-data`. It was added way back in rust-lang#28585 under the name `-Zkeep-mtwt-tables`. The justification was: > This is so that the resolution results can be used after analysis, > potentially for tool support. There are no uses of significance in the code base, and various Google searches for both option names (and variants) found nothing of interest. I think this can safely be removed. r? `@davidtwco`

…nits, r=cjgillot Small improvements in object lifetime default code I found those while trying to understand how the code works.

Compute layout with spans for better cycle errors in coroutines Split out from rust-lang#117703, this PR at least gives us a nicer span to point at when we hit a cycle error in coroutine layout cycles.

…mulacrum Remove some unused stuff from `rustc_index` r? `@Mark-Simulacrum`

…, r=onur-ozkan Cranelift isn't available on non-nightly channels This commit already landed as part of beta branching, this PR just puts it on master.

TaKO8Ki · 2023-11-13T15:54:35Z

@bors r+ rollup=never p=5

bors · 2023-11-13T15:54:38Z

📌 Commit b0a68a4 has been approved by TaKO8Ki

It is now in the queue for this repository.

bors · 2023-11-13T17:29:03Z

⌛ Testing commit b0a68a4 with merge 531cb83...

bors · 2023-11-13T19:40:38Z

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 531cb83 to master...

rust-timer · 2023-11-13T19:42:04Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117737	Remove `-Zkeep-hygiene-data`.	`aaf9e92085b319e3b90d1aa2fe9b7ed4c0ce8482` (link)
#117830	Small improvements in object lifetime default code	`f550dabecd31517286ca3a1b6f793497c2d2bcee` (link)
#117858	Compute layout with spans for better cycle errors in corout…	`1d632bae2c79e0430e46ead8b4fc1cf497bc803f` (link)
#117863	Remove some unused stuff from `rustc_index`	`faa2a7bb9493471534a07265d7b9b50267ce5d4f` (link)
#117872	Cranelift isn't available on non-nightly channels	`1a4c5d6aa56ee400ec47c116d277eaf661b22a74` (link)

previous master: 4bd2fd5c83

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-11-13T21:02:32Z

Finished benchmarking commit (531cb83): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	2.6%	[0.5%, 5.6%]	13
Improvements ✅ (primary)	-1.3%	[-2.1%, -0.6%]	2
Improvements ✅ (secondary)	-4.1%	[-12.0%, -0.8%]	4
All ❌✅ (primary)	-0.6%	[-2.1%, 0.9%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[1.9%, 2.7%]	5
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.906s -> 674.599s (0.10%)
Artifact size: 311.10 MiB -> 311.11 MiB (0.00%)

nnethercote and others added 14 commits November 10, 2023 14:00

Small improvements in object lifetime default code

8bcd221

I found those while trying to understand how the code works.

Compute layout with spans for better cycle errors in coroutines

7994b58

Cranelift isn't available on non-nightly channels

8e2da60

Remove BitSet::words.

06faf58

Remove BitSet::to_hybrid.

b7cf697

Remove impl FiniteBitSetTy for {u64,u128}.

8b18c16

Only the impl for `u32` is used. These can be reinstated easily if needed in the future.

Remove IndexSlice::convert_index_type.

2433542

Remove unnecessary annotation.

82e396a

Rollup merge of rust-lang#117830 - Nilstrieb:object-lifetime-default-…

826b181

…nits, r=cjgillot Small improvements in object lifetime default code I found those while trying to understand how the code works.

Rollup merge of rust-lang#117858 - compiler-errors:span, r=lcnr

cf21b6e

Compute layout with spans for better cycle errors in coroutines Split out from rust-lang#117703, this PR at least gives us a nicer span to point at when we hit a cycle error in coroutine layout cycles.

Rollup merge of rust-lang#117863 - nnethercote:rustc_index, r=Mark-Si…

19bffe1

…mulacrum Remove some unused stuff from `rustc_index` r? `@Mark-Simulacrum`

Rollup merge of rust-lang#117872 - Mark-Simulacrum:fwd-port-cranelift…

b0a68a4

…, r=onur-ozkan Cranelift isn't available on non-nightly channels This commit already landed as part of beta branching, this PR just puts it on master.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 13, 2023

bors merged commit 531cb83 into rust-lang:master Nov 13, 2023

rustbot added this to the 1.76.0 milestone Nov 13, 2023

bors mentioned this pull request Nov 13, 2023

Support async recursive calls (as long as they have indirection) #117703

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #117881

Rollup of 5 pull requests #117881

TaKO8Ki commented Nov 13, 2023

Uh oh!

TaKO8Ki commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

rust-timer commented Nov 13, 2023

Uh oh!

rust-timer commented Nov 13, 2023

Uh oh!

Uh oh!

Rollup of 5 pull requests #117881

Rollup of 5 pull requests #117881

Conversation

TaKO8Ki commented Nov 13, 2023

Uh oh!

TaKO8Ki commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

bors commented Nov 13, 2023

Uh oh!

rust-timer commented Nov 13, 2023

Uh oh!

rust-timer commented Nov 13, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!