Rollup of 8 pull requests #126446
Closed
Rollup of 8 pull requests #126446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.
…rieb Clarify `Command::new` behavior for programs with arguments I mistakenly passed program path along arguments as the same string into `Command::new` a couple of times now. It might be useful to explicitly highlight that `Command::new` intends to accept path to a program, not path to a program plus arguments. Also nudge the user to use `Command::arg` or `Command::args` if they wish to pass arguments.
…ge, r=estebank Indicate in `non_local_defs` lint that the macro needs to change This PR adds a note to indicate that the macro needs to change in the `non_local_definitions` lint output. Address rust-lang#125089 (comment) Fixes rust-lang#125681 r? `@estebank`
[1/2] clean-up / general improvements This PR applies various clippy suggestions on the tools. I have only applied the ones that make sense and left out trivial changes (e.g., suggestions like 'remove &' are ignored to keep the original commit history for the lines). I am planning to do the same for the library and compiler, but those will add too many changes to this PR, so I will handle them in a separate PR later.
Fix wording in {checked_}next_power_of_two
Small documentation update
…, r=scottmcm Small style improvement in `gvn.rs` Allowed by rust-lang#110451 (comment). :P r? ```@scottmcm```
…copy, r=Nilstrieb Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy` A small fix in the `assert_unsafe_precondition` message for `core::ptr::copy` as described by rust-lang#126400 . fixes rust-lang#126400
Remove failing GUI test to stop blocking CI until it is fixed Until rust-lang#126436 is solved, let's unblock rust CI. r? `@lqd`
rustbot
added
A-rustdoc-json
rustbot
added
T-rustdoc
|
🌲 The tree is currently closed for pull requests below priority 13. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
what. |
|
@bors retry |
bors
added
S-waiting-on-bors
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed) r? `@ghost` `@rustbot` modify labels: rollup
|
if that wasn't just a network transmission failure resulting in corrupted data then I guess I better start picking out a sauce for my hat. |
|
At least the rustdoc tests seem fixed, the builder passed in the PR itself, which is a good sign for keeping a hat-free healthy diet |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
delicious hat, got it. |
|
annoying, this had already failed in #126441 but I didn't notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
native-static-libsnote, even if it is empty #121216 (Always emitnative-static-libsnote, even if it is empty)Command::newbehavior for programs with arguments #123726 (ClarifyCommand::newbehavior for programs with arguments)non_local_defslint that the macro needs to change #125722 (Indicate innon_local_defslint that the macro needs to change)gvn.rs#126392 (Small style improvement ingvn.rs)assert_unsafe_preconditionmessage forcore::ptr::copy#126402 (Fix wrongassert_unsafe_preconditionmessage forcore::ptr::copy)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup