opt-dist: make llvm builds optional #143928

ognevny · 2025-07-14T14:54:53Z

adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so #143898 should be addressed for this change

couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host

r? @Kobzol

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc

rustbot · 2025-07-14T14:54:57Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-07-14T14:54:59Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

ognevny · 2025-07-14T17:21:02Z

couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host

after finally managing to create a good environment, I tested this and the change works as intended

src/tools/opt-dist/src/exec.rs

src/tools/opt-dist/src/main.rs

Kobzol

Left two nits, will start a try run in the meantime.

src/tools/opt-dist/src/main.rs

Kobzol · 2025-07-18T08:05:55Z

@bors2 try

opt-dist: make llvm builds optional adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so #143898 should be addressed for this change couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host    r? `@Kobzol` try-job: dist-x86_64-linux try-job: dist-x86_64-msvc

rust-bors · 2025-07-18T08:05:59Z

⌛ Trying commit d9c2a27 with merge d08b352…

To cancel the try build, run the command @bors2 try cancel.

adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized will be already built in Stage 1, so my previous PR should be addressed for this change

rust-bors · 2025-07-18T11:08:17Z

☀️ Try build successful (CI)
Build commit: d08b352 (d08b35280fb8e6cb4ea877781c9531e0e69b9278, parent: 1aa5b2246560ce85b42fa8b33e5927c5de3fa389)

Kobzol · 2025-07-18T13:17:02Z

@rust-timer build d08b352

rust-timer · 2025-07-18T14:27:38Z

Finished benchmarking commit (d08b352): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -6.7%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.7%	[-6.7%, -6.7%]	1
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-6.7%	[-6.7%, -6.7%]	1

Cycles

Results (primary 1.6%, secondary 17.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	17.5%	[2.2%, 26.6%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 464.583s -> 465.606s (0.22%)
Artifact size: 374.66 MiB -> 374.71 MiB (0.02%)

Kobzol · 2025-07-18T15:59:11Z

@bors r+ rollup

bors · 2025-07-18T15:59:14Z

📌 Commit 8e840f7 has been approved by Kobzol

It is now in the queue for this repository.

opt-dist: make llvm builds optional adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so rust-lang#143898 should be addressed for this change couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host r? `@Kobzol` try-job: dist-x86_64-linux try-job: dist-x86_64-msvc

Rollup of 9 pull requests Successful merges: - #138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter) - #142673 (Show the offset, length and memory of uninit read errors) - #142693 (More robustly deal with relaxed bounds and improve their diagnostics) - #143382 (stabilize `const_slice_reverse`) - #143928 (opt-dist: make llvm builds optional) - #143961 (Correct which exploit mitigations are enabled by default) - #144050 (Fix encoding of link_section and no_mangle cross crate) - #144059 (Refactor `CrateLoader` into the `CStore`) - #144123 (Generalize `unsize` and `unsize_into` destinations) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143928 - ognevny:opt-dist-build-llvm, r=Kobzol opt-dist: make llvm builds optional adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so #143898 should be addressed for this change couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host r? ``@Kobzol`` try-job: dist-x86_64-linux try-job: dist-x86_64-msvc

Rollup of 9 pull requests Successful merges: - rust-lang/rust#138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter) - rust-lang/rust#142673 (Show the offset, length and memory of uninit read errors) - rust-lang/rust#142693 (More robustly deal with relaxed bounds and improve their diagnostics) - rust-lang/rust#143382 (stabilize `const_slice_reverse`) - rust-lang/rust#143928 (opt-dist: make llvm builds optional) - rust-lang/rust#143961 (Correct which exploit mitigations are enabled by default) - rust-lang/rust#144050 (Fix encoding of link_section and no_mangle cross crate) - rust-lang/rust#144059 (Refactor `CrateLoader` into the `CStore`) - rust-lang/rust#144123 (Generalize `unsize` and `unsize_into` destinations) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Kobzol Jul 14, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2025

Kobzol reviewed Jul 17, 2025

View reviewed changes

src/tools/opt-dist/src/exec.rs Outdated Show resolved Hide resolved

ognevny force-pushed the opt-dist-build-llvm branch from 47e8d57 to 9295c2f Compare July 17, 2025 20:58

Kobzol reviewed Jul 18, 2025

View reviewed changes

src/tools/opt-dist/src/main.rs Outdated Show resolved Hide resolved

ognevny force-pushed the opt-dist-build-llvm branch from 9295c2f to d9c2a27 Compare July 18, 2025 08:01

Kobzol reviewed Jul 18, 2025

View reviewed changes

src/tools/opt-dist/src/main.rs Outdated Show resolved Hide resolved

src/tools/opt-dist/src/main.rs Outdated Show resolved Hide resolved

ognevny force-pushed the opt-dist-build-llvm branch from d9c2a27 to 8e840f7 Compare July 18, 2025 08:20

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025

This was referenced Jul 18, 2025

Rollup of 10 pull requests #144138

Closed

Rollup of 9 pull requests #144145

Merged

bors merged commit 232bef3 into rust-lang:master Jul 19, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 19, 2025

ognevny deleted the opt-dist-build-llvm branch July 19, 2025 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

opt-dist: make llvm builds optional #143928

opt-dist: make llvm builds optional #143928

ognevny commented Jul 14, 2025 •

edited by Kobzol

Loading

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

ognevny commented Jul 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Kobzol left a comment

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

rust-bors bot commented Jul 18, 2025

Uh oh!

rust-bors bot commented Jul 18, 2025

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 18, 2025

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

bors commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

opt-dist: make llvm builds optional #143928

opt-dist: make llvm builds optional #143928

Conversation

ognevny commented Jul 14, 2025 • edited by Kobzol Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

ognevny commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

rust-bors bot commented Jul 18, 2025

Uh oh!

rust-bors bot commented Jul 18, 2025

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 18, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Jul 18, 2025

Uh oh!

bors commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

ognevny commented Jul 14, 2025 •

edited by Kobzol

Loading

ognevny commented Jul 14, 2025 •

edited

Loading