Don't test panic=unwind in panic_main.rs on Fuchsia #144073
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
|
actually, I think we should just mark them as |
|
@lqd good idea, I'll switch to |
Only run the panic=unwind tests on platforms that support unwinding.
erickt
force-pushed
the
ignore-test-on-fuchsia
branch
from
1283116 to
0a71873
Compare
Enselic
approved these changes
Jul 17, 2025
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 18, 2025
Don't test panic=unwind in panic_main.rs on Fuchsia `@Enselic` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia. Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here. cc `@compile-errors,` who reviewed the initial PR
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2025
Don't test panic=unwind in panic_main.rs on Fuchsia ``@Enselic`` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia. Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here. cc ``@compile-errors,`` who reviewed the initial PR
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2025
Don't test panic=unwind in panic_main.rs on Fuchsia ```@Enselic``` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia. Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here. cc ```@compile-errors,``` who reviewed the initial PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Enselic added a few new test conditions to tests/ui/panics/panic-main.rs in #142304, but it is unfortunately causing the test to fail for Fuchsia with the
panic=unwindmodes since we compile Rust for Fuchsia withpanic=abort. This patch just ignores the test for Fuchsia.Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.
cc @compile-errors, who reviewed the initial PR