Rollup of 12 pull requests #144075
Closed
Rollup of 12 pull requests #144075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external-repos.md: small fixes
Partially reverts commit 40311c4.
See RUST-141600: this test is broken in two ways: 1. This test triggers `-Wincompatible-pointer-types` on GCC 14. 2. This test requires ARMv8.5+ w/ MTE extensions enabled, but GHA CI runner hardware do not have this enabled.
./x is recommended over running ./x.py directly, and is the more commonly-used invocation of bootstrap in the guide
use a consistent (and recommended) invocation
- --depth=1 is more useful for once-off uses, like on ci - .git postfix on github repo url is not needed
That is, calling it an example is misleading
Nowhere else is this called "Dist check"
add missing word
do not invent a name
distcheck has only one possible invocation
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup of 12 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144034 (tests: Test line number in debuginfo for diverging function calls) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
cc @rust-lang/miri fn test_nanosleep() {
let start_test_sleep = Instant::now();
let duration_zero = libc::timespec { tv_sec: 0, tv_nsec: 0 };
let remainder = ptr::null_mut::<libc::timespec>();
let is_error = unsafe { libc::nanosleep(&duration_zero, remainder) };
assert_eq!(is_error, 0);
assert!(start_test_sleep.elapsed() < Duration::from_millis(10));
let start_test_sleep = Instant::now();
let duration_100_millis = libc::timespec { tv_sec: 0, tv_nsec: 1_000_000_000 / 10 };
let remainder = ptr::null_mut::<libc::timespec>();
let is_error = unsafe { libc::nanosleep(&duration_100_millis, remainder) };
assert_eq!(is_error, 0);
assert!(start_test_sleep.elapsed() > Duration::from_millis(100));
}
`` |
|
hmm... we could give it more leeway in CI I guess? |
|
Damn, sorry for that. Let me check how much slack the other timing tests add, I think we usually give them 1s even for a 10ms sleep because CI runners can pause awkwardly long. |
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jul 17, 2025
miri sleep tests: increase slack Filing this directly as a rustc PR since it impacts rustc CI (see rust-lang#144075 (comment)) r? `@oli-obk`
bors
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup of 12 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144034 (tests: Test line number in debuginfo for diverging function calls) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 18, 2025
miri sleep tests: increase slack Filing this directly as a rustc PR since it impacts rustc CI (see rust-lang#144075 (comment)) r? ``@oli-obk``
rustbot
removed
the
S-waiting-on-review
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2025
miri sleep tests: increase slack Filing this directly as a rustc PR since it impacts rustc CI (see rust-lang#144075 (comment)) r? ```@oli-obk```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 18, 2025
miri sleep tests: increase slack Filing this directly as a rustc PR since it impacts rustc CI (see rust-lang#144075 (comment)) r? ````@oli-obk````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tests/run-make/mte-ffibecause no CI runners have MTE extensions enabled #142300 (Disabletests/run-make/mte-ffibecause no CI runners have MTE extensions enabled)-Zsanitizer=kcfion#[naked]functions #143293 (fix-Zsanitizer=kcfion#[naked]functions)-oand arg #143719 (Emit warning when there is no space between-oand arg)#[coverage]to the new attribute system #143891 (Port#[coverage]to the new attribute system)Optionmethods #143967 (constifyOptionmethods)optimize = false#144010 (Boostrap: add warning onoptimize = false)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup