Subtree update of rust-analyzer
#144114
Merged
Subtree update of rust-analyzer
#144114
+3,731
−1,185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayashi Mikihiro <[email protected]>
Signed-off-by: Hayashi Mikihiro <[email protected]>
Signed-off-by: Hayashi Mikihiro <[email protected]>
Even when at curly braces, otherwise the parser can get stuck. This has happened in the past in rust-lang#18625, but it was just worked around instead of handling the root of the problem. Now this happened again in rust-lang#20171. IMO we can't let `err_and_bump()` not bump, that's too confusing and invites errors. We can (as I did) workaround the worse recovery instead.
I opted to not include enum variant imports, only under the enum, and to not gate this behind a setting.
feat: Include enum variants in world symbols
Which caused a panic.
fix: Always bump in the parser in `err_and_bump()`
fix: Fix a case where the link type was `None`
Signed-off-by: Hayashi Mikihiro <[email protected]>
…ent_up Migrate `pull_assignment_up` assist to use`SyntaxEditor`
…xrvpywtvoys Revert "Re-enable fixpoint iteration for variance computation"
There is no need to, it's already stored in the `kind`.
…nd make only `asm!()` unsafe
…field feat: Generate `new` for tuple struct
Because apparently, we were not accepting inline asm in item position, completely breaking it.
…ditor' Signed-off-by: Hayashi Mikihiro <[email protected]>
It's failing to much. We need to fix it, but my changes are unlikely to be the cause.
…ed_struct Migrate `convert_named_struct_to_tuple_struct` assist to use 'SyntaxEditor'
Update MSRV to 1.88.0
We need it because `global_asm!()` is an item. It's unfortunate that such thing can slip in and I see no way to automatically catch that, but thankfully analysis-stats on self has caught that.
And leave only the type stuff without it. This is because most expression stores don't have anything but types (e.g. generics, fields, signatures) so this saves a lot of memory. This saves 58mb on `analysis-stats .`.
- AsRef -> AsMut
- Borrow -> BorrowMut
Example
====================
```rust
//- minicore: as_ref
struct Foo(i32);
impl<T> core::convert::AsRef$0<i32> for Foo {
fn as_ref(&self) -> &i32 {
&self.0
}
}
```
->
```rust
struct Foo(i32);
$0impl<T> core::convert::AsMut<i32> for Foo {
fn as_mut(&mut self) -> &mut i32 {
&self.0
}
}
impl<T> core::convert::AsRef<i32> for Foo {
fn as_ref(&self) -> &i32 {
&self.0
}
}
```
Add AsMut to minicore prelude::v1
Add AsRef and Borrow for generate_mut_trait_impl
Add tailexpr & -> &mut for generate_mut_trait_impl
* `examples/minimal_lsp.rs` – compact LSP server showing definition, completion, hover, rustfmt-based formatting, and dummy diagnostics. Advertises UTF-8 offset encoding. * `examples/manual_test.sh` – FIFO script that streams the canonical nine LSP packets so anyone can validate the server from two terminals. No new runtime deps; `anyhow` stays under [dev-dependencies].
…e-clean examples: add `minimal_lsp.rs` and FIFO test script
…d-from Add ide-assist, generate single field struct From
minor: Update lockfile
rustbot
added
the
S-waiting-on-review
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
|
@bors r+ p=1 subtree sync |
bors
added
S-waiting-on-bors
|
@bors p=6 sandwiching between rollups |
|
Rolling it up should be fine too. |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6c0a912 (parent) -> 6caa224 (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6caa224a242d4c7b06c317969c51862815a4454b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (6caa224): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.7%, secondary 4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.309s -> 465.653s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost