Skip to content

Fixes for LLVM 21 #144116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for LLVM 21 #144116

wants to merge 3 commits into from
+28 −6

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jul 18, 2025

This fixes compatibility issues with LLVM 21 without performing the actual upgrade. Split out from #143684.

This fixes three issues:

  • Updates the AMDGPU data layout for address space 8.
  • Makes emit-arity-indicator.rs a no_core test, so it doesn't fail on non-x86 hosts.
  • Explicitly sets the exception model for wasm, as this is no longer implied by -wasm-enable-eh.

nikic added 3 commits July 18, 2025 09:35
@nikic
Update AMDGPU data layout
63e1074
@nikic
Pass wasm exception model to TargetOptions
12b19be 
This is no longer implied by -wasm-enable-eh.
@nikic
Make emit-arity-indicator.rs a no_core test
a65563e 
The presence of `@add-core-stubs` indicates that this was already
intended.
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@nikic nikic mentioned this pull request Jul 18, 2025
Closed
rust-bors bot added a commit that referenced this pull request Jul 18, 2025
@rust-bors
Auto merge of #144117 - nikic:llvm-21-host, r=<try>
eeb3bdc 
Update dist-x86_64-linux host toolchain to LLVM 21

This updates the host clang used to build LLVM, as well as llvm-bolt. This avoids the bolt miscompile encountered in #144116.

r? `@ghost`
@dianqk
Copy link
Member

dianqk commented Jul 18, 2025

r? dianqk @bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit a65563e has been approved by dianqk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dianqk dianqk

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikic @rustbot @dianqk @bors @compiler-errors