-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Write .cargo/config.toml in x vendor #144124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @clubby789 rustbot has assigned @clubby789. Use |
Why not just print out the config info captured? That avoids the trailing
and avoids automatically overwriting a potentially existing config.toml. |
I found this will working on vendoring support for |
Sounds good - the broken output is a bit unfortunate but not the end of the world. r=me when green |
I don't think people will appreciate when running |
} | ||
|
||
impl Step for Vendor { | ||
type Output = VendorOutput; | ||
type Output = (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this? GenerateCopyright
can still make use of the final path, instead of having to know about VENDOR_DIR
, which is an implementation detail of the vendor step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VendorOutput
only ever contained the data that should be written to .cargo/config.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like overwriting the config.toml file on disk (as per my other comment), but if we did that, we can at least return the path to the vendor directory from the step, to avoid other steps reaching for VENDOR_DIR
.
x vendor hides the cargo vendor telling you what to write to
.cargo/config.toml
. to use the vendored sources, so without this PR it isn't obvious how to use the vendored sources.