Skip to content

stdarch subtree update #144222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Jul 22, 2025
Merged

stdarch subtree update #144222

merged 65 commits into from
Jul 22, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 20, 2025

Subtree update of stdarch to rust-lang/stdarch@5531955.

Created using https://github.com/rust-lang/josh-sync.

I saw that there were non-trivial changes made to std_detect in stdarch recently. So I want to get them merged here before we move forward with #143412.

r? @folkertdev

heiher and others added 30 commits June 28, 2025 11:28
Add sayantn and folkertdev as reviewers
use `splat` for the aarch64/arm dup intrinsics
…x-gnueabihf-clippy-fixes

thumbv7neon-unknown-linux-gnueabihf clippy fixes
…erators

aarch64: use `core::intrinsics::simd` for integer min/max
…-static

`stdarch-gen-arm`: remove `lazy_static`, use `LazyLock` instead
…test

`intrinsic-test`: use runner also for rust
Add rustc-pull CI automation workflow
`aarch64`: use more of `intrinsics::simd` for min/max
loongarch: Add basic support for LoongArch32
…intrinsic

`s390x`: document the different rounding flavors
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@folkertdev
Copy link
Contributor

we usually don't rollup these right?

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

📌 Commit 9b7d31c has been approved by folkertdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 20, 2025

I think we could, but doesn't really matter.

@Kobzol
Copy link
Member Author

Kobzol commented Jul 22, 2025

I'm gonna go ahead and bump this one up, so that we don't get more conflicts with stdarch, the move of std_detect into rustc is potentially conflict-prone.

@bors p=1

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

⌛ Testing commit 9b7d31c with merge 2e53675...

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

☀️ Test successful - checks-actions
Approved by: folkertdev
Pushing 2e53675 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2025
@bors bors merged commit 2e53675 into rust-lang:master Jul 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 22, 2025
@Kobzol Kobzol deleted the stdarch-push branch July 22, 2025 18:39
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 35487a2 (parent) -> 2e53675 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2e5367566819ca7878baa9600ae7a93eb0e37bbf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 4357.9s -> 6596.7s (51.4%)
  2. dist-x86_64-apple: 13292.7s -> 10898.7s (-18.0%)
  3. x86_64-gnu-llvm-20-2: 5535.7s -> 6364.8s (15.0%)
  4. dist-apple-various: 9840.3s -> 8476.8s (-13.9%)
  5. dist-aarch64-apple: 6139.0s -> 5326.0s (-13.2%)
  6. dist-x86_64-netbsd: 5217.7s -> 4615.6s (-11.5%)
  7. dist-ohos-armv7: 4210.1s -> 3823.2s (-9.2%)
  8. dist-x86_64-windows-gnullvm: 5912.3s -> 5405.7s (-8.6%)
  9. dist-powerpc64-linux: 5397.8s -> 4946.4s (-8.4%)
  10. x86_64-apple-2: 4673.6s -> 4286.4s (-8.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2e53675): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-4.4%, -2.9%] 3
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.2%, 3.2%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.187s -> 465.103s (-0.02%)
Artifact size: 374.60 MiB -> 374.58 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants