Skip to content

Stabilize loongarch32 inline asm #144402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize loongarch32 inline asm #144402

wants to merge 1 commit into from
+158 −46

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jul 24, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@Amanieu Amanieu added the I-lang-nominated Nominated for discussion during a lang team meeting. label Jul 24, 2025
@Amanieu
Copy link
Member

Amanieu commented Jul 24, 2025

LGTM but needs a @rust-lang/lang FCP.

Also this needs a PR to update the asm page in the reference.

@heiher heiher force-pushed the stabilize-loong32-asm branch from 3e844ba to a383fb0 Compare July 24, 2025 14:01
@heiher
Copy link
Contributor Author

heiher commented Jul 24, 2025

LGTM but needs a @rust-lang/lang FCP.

Also this needs a PR to update the asm page in the reference.

rust-lang/reference#1942

@ehuss ehuss mentioned this pull request Jul 24, 2025
Open
@traviscross traviscross added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@traviscross
Copy link
Contributor

Thanks for filing the Reference PR.

With a great reliance on @Amanieu's say-so that this is OK, I propose...

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 24, 2025 •
edited by joshtriplett
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. I-lang-nominated Nominated for discussion during a lang team meeting. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-lang Relevant to the language team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heiher @Amanieu @traviscross @rfcbot @rustbot