-
Notifications
You must be signed in to change notification settings - Fork 13.6k
ci: Begin running ui tests with rust.debuginfo-level-tests=1
#144499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
This PR modifies |
To reduce risk of regressing on generating debuginfo e.g. in the form of ICE:s. This will also ensure that future ui tests support different debuginfo levels. When I looked at run time for different CI jobs, **x86_64-gnu-debug** was far from the bottle neck, so it should be fine to make it perform more work.
8e58746
to
4996539
Compare
Can someone trigger the following try job please? Thanks in advance. @bors2 try jobs=x86_64-gnu-debug |
@Enselic: 🔑 Insufficient privileges: not in try users |
@bors try jobs=x86_64-gnu-debug |
ci: Begin running ui tests with `rust.debuginfo-level-tests=1` try-job: x86_64-gnu-debug
To reduce risk of regressing on generating debuginfo e.g. in the form of ICE:s. This will also ensure that future ui tests work with different debuginfo levels. See #61117.
When I looked at run time for different CI jobs, x86_64-gnu-debug was far from the bottleneck, so it should be fine to make it perform more work.
A handful of tests are failing so we need to force debuginfo=0 on those for now.
We'll start small with debuginfo=1. We'll step up to debuginfo=2 once most (all?) tests can handle debuginfo=1. There are more failures with debuginfo=2 than with debuginfo=1.