Skip to content

ci: Begin running ui tests with rust.debuginfo-level-tests=1 #144499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jul 26, 2025

To reduce risk of regressing on generating debuginfo e.g. in the form of ICE:s. This will also ensure that future ui tests work with different debuginfo levels. See #61117.

When I looked at run time for different CI jobs, x86_64-gnu-debug was far from the bottleneck, so it should be fine to make it perform more work.

A handful of tests are failing so we need to force debuginfo=0 on those for now.

We'll start small with debuginfo=1. We'll step up to debuginfo=2 once most (all?) tests can handle debuginfo=1. There are more failures with debuginfo=2 than with debuginfo=1.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

To reduce risk of regressing on generating debuginfo e.g. in the form of
ICE:s. This will also ensure that future ui tests support different
debuginfo levels.

When I looked at run time for different CI jobs, **x86_64-gnu-debug**
was far from the bottle neck, so it should be fine to make it perform
more work.
@Enselic Enselic force-pushed the ci-debuginfo-level-tests branch from 8e58746 to 4996539 Compare July 26, 2025 13:33
@Enselic
Copy link
Member Author

Enselic commented Jul 26, 2025

Can someone trigger the following try job please? Thanks in advance.

@bors2 try jobs=x86_64-gnu-debug

@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

@Enselic: 🔑 Insufficient privileges: not in try users

@lqd
Copy link
Member

lqd commented Jul 26, 2025

@bors try jobs=x86_64-gnu-debug

rust-bors bot added a commit that referenced this pull request Jul 26, 2025
ci: Begin running ui tests with `rust.debuginfo-level-tests=1`

try-job: x86_64-gnu-debug
@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

⌛ Trying commit 4996539 with merge 0b6a4a3

To cancel the try build, run the command @bors try cancel.

@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

☀️ Try build successful (CI)
Build commit: 0b6a4a3 (0b6a4a3e360d2c8111499ac33a5aa1289e8fa845, parent: 133798f9fb2887bcccf1098937540e280dd58465)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants