-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Rehome 21 tests/ui/issues/
tests to other subdirectories under tests/ui/
#144548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This comment has been minimized.
This comment has been minimized.
tests/ui/issues/
tests to other subdirectories under tests/ui/
tests/ui/issues/
tests to other subdirectories under tests/ui/
6b978c5
to
6b48664
Compare
This PR modifies |
This comment has been minimized.
This comment has been minimized.
6b48664
to
a9ed9a4
Compare
For future PRs like this where you have both moves and edits, can you make sure to split the changes into two commits, with commit 1 being move-only, and commit 2 being edits? This is intended to make it easier to navigate git history. I wouldn't worry so much about PRs you already have opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few issues
tests/ui/array-slice-vec/collection-type-copy-behavior-12909.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: test name is wrong, should be #46471
tests/ui/macros/macro-expansion-bypasses-derive-stability-32655.rs
Outdated
Show resolved
Hide resolved
tests/ui/trait-bounds/incorrect-self-type-in-trait-impl-48276.rs
Outdated
Show resolved
Hide resolved
tests/ui/trait-bounds/parenthesized-type-parameters-error-329952.rs
Outdated
Show resolved
Hide resolved
tests/ui/trait-bounds/parenthesized-type-parameters-error-329952.rs
Outdated
Show resolved
Hide resolved
tests/ui/trait-bounds/parenthesized-type-parameters-error-329952.stderr
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you squash after removing stray stderr?
@Oneirical |
dedb801
to
ee8e809
Compare
I have never heard of such a tool! In fact, we were talking about making something like this in the Google Summer of Code chat, but it never solidified into anything. I'll definitely be looking into this!! |
This comment has been minimized.
This comment has been minimized.
We already moved hundreds (probably >1000) tests using it as a part of #73494, it's quite strange that you haven't seen it and @jieyouxu didn't mention it. |
ee8e809
to
807d340
Compare
@rustbot review |
#143902 divided into smaller, easier to review chunks.
Part of #133895
Methodology:
tests/ui/SUMMARY.md
Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu