make some vecdeque methods const #144612
make some vecdeque methods const #144612
Conversation
rustbot
added
S-waiting-on-review
| @@ -713,7 +714,8 @@ impl<T, A: Allocator> VecDeque<T, A> { | |||
| /// assert_eq!(buf[1], 7); | |||
| /// ``` | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub fn get_mut(&mut self, index: usize) -> Option<&mut T> { | |||
| #[rustc_const_stable(feature = "const_vecdeque_methods", since = "1.90.0")] | |||
There was a problem hiding this comment.
This would make these immediately stable, which we don't want to do. Please change this to rustc_const_unstable and create a new tracking issue.
| @@ -168,7 +168,7 @@ impl<T, A: Allocator> VecDeque<T, A> { | |||
| /// | |||
| /// May only be called if `deque.len() < deque.capacity()` | |||
| #[inline] | |||
| unsafe fn push_unchecked(&mut self, element: T) { | |||
| const unsafe fn push_unchecked(&mut self, element: T) { | |||
There was a problem hiding this comment.
This function is internal-only and doesn't seem to need to be const to support public API. Please drop changes to anything that isn't strictly necessary to support making the public functions in this PR const, to make it clear exactly what we're (unstably) committing to here.
The same thing applies to a handful of function here
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
☔ The latest upstream changes (presumably #144718) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks like some of the methods on
VecDequecan be made const. I have tried making as many of them const as I could.