Skip to content

Use new public libtest ERROR_EXIT_CODE constant in rustdoc #144739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use new public libtest ERROR_EXIT_CODE constant in rustdoc #144739

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 31, 2025 •
edited by rustbot
Loading

Followup of #144297.

@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 31, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

Ah, I guess I need to wait one day before the CI can pass...

@fmease fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@fmease fmease assigned fmease and unassigned notriddle Jul 31, 2025
@fmease
Copy link
Member

fmease commented Jul 31, 2025 •
edited
Loading

r=me once unblocked.
@bors rollup

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@fmease
Copy link
Member

fmease commented Aug 1, 2025

Still private even tho it's pub on master, is test from the sysroot of the bootstrap/beta compiler? 🤔

@GuillaumeGomez
Copy link
Member Author

Wondering the same thing. Do you know @Kobzol by any chance?

@Kobzol
Copy link
Member

Kobzol commented Aug 1, 2025

Stage 1 rustdoc is compiled with stage 0 rustc, which means that it uses the stage 0 stdlib.

@Kobzol
Copy link
Member

Kobzol commented Aug 1, 2025

In other words, you have to wait for a stage0 bump. But since today beta is being branched off, it should happen soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rustbot @rust-log-analyzer @fmease @Kobzol @notriddle