-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Update rustdoc.md to point to correct file. #144854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @GuillaumeGomez. Use |
Thanks! @bors r+ rollup |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors r- |
@@ -1,3 +1,3 @@ | |||
% Rust Documentation | |||
|
|||
This has been moved [into the rustdoc book](rustdoc/index.html). | |||
This has been moved [into the rustdoc book](rustdoc/src/SUMMARY.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in the final output what you want is not a markdown file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe clarify what your question? The previous link to rustdoc/index.html
does not exist anymore. I was perusing the codebase and it sent me to a 404 page. It seemed to me like it should link to the rustdoc src
directory, so I updated the link.
Actually the link is not broken, it just doesn't work on Github md preview (but works fine on the website.) Other pages also include similar links e.g. https://github.com/rust-lang/rust/blob/master/src/doc/guide-unsafe.md. Changing it to pointing to a md file will result in an invalid link on the website. |
Good catch @slanterns. Closing this PR then |
Noticed the link was broken, Found what seemed like a reasonable file to point to instead.