Couple of minor cleanups #145004
Open
Couple of minor cleanups #145004
+37
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
A-LLVM
|
Some changes occurred in compiler/rustc_codegen_ssa These commits modify compiler targets. |
WaffleLapkin
approved these changes
Aug 6, 2025
|
r=me with green ci |
|
@bors r=WaffleLapkin |
bors
added
S-waiting-on-bors
|
cc #117364 which removed embedding of LLVM bitcode on Apple platforms. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 7, 2025
…fleLapkin Couple of minor cleanups
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 7, 2025
…fleLapkin Couple of minor cleanups
bors
added a commit
that referenced
this pull request
Aug 7, 2025
Rollup of 20 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144807 (Streamline config in bootstrap) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - #144974 (compiler-builtins subtree update) - #144997 (bump bootstrap compiler to 1.90 beta) - #145004 (Couple of minor cleanups) - #145009 (A couple small changes for rust-analyzer next-solver work) - #145014 (Revert "Preserve the .debug_gdb_scripts section") r? `@ghost` `@rustbot` modify labels: rollup
klensy
reviewed
Aug 7, 2025
Comment on lines
1113
to
1116
|
|
||
| let llconst = common::bytes_in_context(llcx, cmdline.as_bytes()); | ||
| let llglobal = llvm::add_global(llmod, common::val_ty(llconst), c"rustc.embedded.cmdline"); | ||
| llvm::set_initializer(llglobal, llconst); |
There was a problem hiding this comment.
Commit says about removing bitcode_llvm_cmdline for apple platform, but if guarded by aix and wasm too?
There was a problem hiding this comment.
It has never been used outside of Apple platforms in the first place afaik. Apple platforms were the only ones where bitcode_llvm_cmdline got set to a non-empty value.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 7, 2025
…fleLapkin Couple of minor cleanups
bors
added a commit
that referenced
this pull request
Aug 7, 2025
Rollup of 8 pull requests Successful merges: - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144974 (compiler-builtins subtree update) - #145004 (Couple of minor cleanups) - #145007 (Fix build/doc/test of error index generator) - #145018 (Derive `Hash` for rustc_public types) r? `@ghost` `@rustbot` modify labels: rollup
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 7, 2025
…fleLapkin Couple of minor cleanups
|
@bors r- Thinking this could be the "Object file with bitcode missing"error in #145063 (comment) |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
rust-bors bot
added a commit
that referenced
this pull request
Aug 8, 2025
Couple of minor cleanups try-job: x86_64-apple-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed (CI). Failed jobs:
|
It used to be necessary on Apple platforms to ship with the App Store, but XCode 15 has stopped embedding LLVM bitcode and the App Store no longer accepts apps with bitcode embedded.
|
On macOS the linker rejects object files with bitcode but missing cmdline. I changed it to keep the cmdline on all platforms, just always empty. |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
bjorn3
force-pushed
the
remove_unused_fields
branch
from
6fbea4f to
8f648d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.