[WIP] Move more early buffered lints to dyn lint diagnostics #145881
+146
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
fmease
added
the
rla-silenced
fmease
force-pushed
the
mv-var-to-dyn-buf-lints
branch
from
1b20034 to
fa582a9
Compare
fmease
force-pushed
the
mv-var-to-dyn-buf-lints
branch
from
fa582a9 to
5e2b622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #145747.
TODO: Migrate more variants. Presently, it's unclear if it's possible to migrate all variants to dyn lint diagnostics without regressing performance because for some early lints
decorate_builtin_lintperforms a bit more work (past PR #124417 has shown that eagerly decorating early lints is incredibly heavy and we had to revert back to lazily decorating in #125410). Let's see how this fares once I tackle the more 'risky' variants).cc @joshtriplett (you can immediately unsubscribe again, I just want to prevent duplicate efforts).