Skip to content

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Oct 28, 2025

11 commits in 344c4567c634a25837e3c3476aac08af84cf9203..6c1b6100343691341b9e76c5acc594e78220f963
2025-10-15 15:01:32 +0000 to 2025-10-28 16:27:52 +0000

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2025
@weihanglo weihanglo self-assigned this Oct 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Oct 29, 2025

📌 Commit f583ecd has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2025
@bors
Copy link
Collaborator

bors commented Oct 29, 2025

⌛ Testing commit f583ecd with merge 4146079...

@bors
Copy link
Collaborator

bors commented Oct 29, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4146079 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2025
@bors bors merged commit 4146079 into rust-lang:master Oct 29, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 29, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 907705a (parent) -> 4146079 (this PR)

Test differences

Show 34 test diffs

Stage 2

  • bad_config::unsupported_int_array: pass -> [missing] (J0)
  • build_analysis::log_msg_build_started: [missing] -> pass (J0)
  • build_analysis::one_logfile_per_invocation: [missing] -> pass (J0)
  • build_analysis::simple: pass -> [missing] (J0)
  • cargo_config::get_json_with_array_any_types: [missing] -> pass (J0)
  • cargo_config::get_toml_with_array_any_types: [missing] -> pass (J0)
  • cargo_config::show_origin_toml_with_array_any_types: [missing] -> pass (J0)
  • cargo_tree::dupe::all_flag: [missing] -> pass (J0)
  • config::array_env: [missing] -> pass (J0)
  • config::array_of_any_types: [missing] -> pass (J0)
  • config::mixed_type_array: [missing] -> pass (J0)
  • config::nested_array: [missing] -> pass (J0)
  • config::non_string_in_array: pass -> [missing] (J0)
  • git_shallow::git2_fetch_complete_dep_two_revs: pass -> [missing] (J0)
  • git_shallow::git_cli_fetch_complete_index_then_shallow: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_complete_then_gitoxide_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_branch_and_rev: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_branch_to_rev: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_then_git2_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_then_git_cli_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_then_gitoxide_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_dep_two_revs: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_index_then_abort_and_update: [missing] -> ignore (Git CLI cannot recover from stale lock files) (J0)
  • git_shallow::git_cli_fetch_shallow_index_then_git2_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_index_then_gitoxide_fetch_complete: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_index_then_gitoxide_fetch_shallow: [missing] -> pass (J0)
  • git_shallow::git_cli_fetch_shallow_index_then_preserve_shallow: [missing] -> pass (J0)
  • git_shallow::gitoxide_fetch_complete_index_then_git_cli_fetch_shallow: [missing] -> pass (J0)
  • git_shallow::gitoxide_fetch_shallow_dep_then_git_cli_fetch_complete: [missing] -> pass (J0)
  • git_shallow::gitoxide_fetch_shallow_index_then_git_cli_fetch_complete: [missing] -> pass (J0)
  • git_shallow::gitoxide_fetch_shallow_index_then_git_cli_fetch_shallow: [missing] -> pass (J0)
  • util::context::key::tests::array_item_key_path_display: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4146079cee94242771864147e32fb5d9adbd34f8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-msvc: 7432.6s -> 5807.4s (-21.9%)
  2. dist-aarch64-apple: 7966.2s -> 6313.4s (-20.7%)
  3. dist-ohos-x86_64: 4078.8s -> 4696.1s (15.1%)
  4. aarch64-gnu-llvm-20-2: 2578.0s -> 2234.6s (-13.3%)
  5. aarch64-apple: 8740.8s -> 7692.7s (-12.0%)
  6. i686-gnu-2: 6216.4s -> 5471.4s (-12.0%)
  7. x86_64-rust-for-linux: 3037.8s -> 2687.8s (-11.5%)
  8. aarch64-gnu-debug: 4310.8s -> 3815.0s (-11.5%)
  9. dist-x86_64-apple: 7110.6s -> 6312.8s (-11.2%)
  10. test-various: 6304.7s -> 7006.2s (11.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4146079): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.5%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)
4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) 3.5% [3.5%, 3.5%] 1

Cycles

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [2.3%, 4.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-4.8%, -2.5%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.692s -> 480.976s (1.32%)
Artifact size: 390.07 MiB -> 390.24 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants