[rustdoc] Remove UrlFragment::render method to unify clean::types::links and anchor
#149028
+48
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Contributor
|
I think we should block this on #149026 just to be safe. |
Contributor
There was a problem hiding this comment.
Looks pretty good, just a few nits.
I am somewhat tempted to say in the future we should also unify the impl block section naming into the same function so that this same logic can be used for sidebar generation, but I'm not sure if that would be better than the status quo or not.
Comment on lines
+174
to
+177
| DefKind::AssocFn if tcx.associated_item(def_id).defaultness(tcx).has_value() => { | ||
| Self::Method | ||
| } | ||
| DefKind::AssocFn => Self::TyMethod, |
Contributor
There was a problem hiding this comment.
nit: I would personally use an if/else here instead of a match guard, but it's subjective.
| let item_type = | ||
| ItemType::from_def_kind(def_kind, Some(tcx.def_kind(parent_def_id))); | ||
| format!("#{}.{}", item_type.as_str(), tcx.item_name(did)) | ||
| pub(crate) fn anchor(did: DefId, tcx: TyCtxt<'_>) -> String { |
Contributor
There was a problem hiding this comment.
I would call this fragment, since "anchor" can also refer to the whole <a> element.
Member
Author
I actually tested with this one but I don't mind waiting. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148648.
First part of #148547.
The last part will be about handle
AssocItemLinkdifferently (either remove it or change how we do it).r? @lolbinarycat