Skip to content

[WIP] resolve: Make ambiguity checking stricter #149145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] resolve: Make ambiguity checking stricter #149145

wants to merge 1 commit into from

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Nov 20, 2025 •
edited by rustbot
Loading

Testing a possible proper fix for the RustEmbed issue (#147196).
cc @LorrensP-2158466

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 20, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 20, 2025
@rust-bors
Auto merge of #149145 - petrochenkov:visambig, r=<try>
0e7f93c 
[WIP] resolve: Make ambiguity checking stricter
@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 20, 2025

💔 Test for 0e7f93c failed: CI. Failed jobs:

@rustbot

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 20, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Nov 20, 2025
@rust-bors
Auto merge of #149145 - petrochenkov:visambig, r=<try>
724e787 
[WIP] resolve: Make ambiguity checking stricter
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 20, 2025

☀️ Try build successful (CI)
Build commit: 724e787 (724e78794d2cf06eef820a24c9a4608d63435e1d, parent: 2c0f4860cc86e2354a55ea04e738848168435c90)

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 21, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Nov 21, 2025

👌 Experiment pr-149145 created and queued.
🤖 Automatically detected try build 724e787
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@petrochenkov petrochenkov mentioned this pull request Nov 25, 2025
Open
@craterbot
Copy link
Collaborator

craterbot commented Nov 26, 2025

🚧 Experiment pr-149145 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Nov 27, 2025

🎉 Experiment pr-149145 is completed!
📊 1725 regressed and 8 fixed (741156 total)
📊 1997 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149145/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 27, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

☔ The latest upstream changes (presumably #149462) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Dec 3, 2025

Closing in favor of #149596.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@petrochenkov @rustbot @rust-log-analyzer @craterbot @bors @jackh726