- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Move the query system to a dedicated crate #70162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            31 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      8c1c90b
              
                Make QueryConfig argument a type.
              
              
                cjgillot f74fd03
              
                Make QueryAccessor argument a type.
              
              
                cjgillot 57c3177
              
                Make QueryDescription parameter a type.
              
              
                cjgillot c4a451e
              
                Make QueryCache generic on the context.
              
              
                cjgillot ee9781c
              
                Make QueryContext a subtrait of DepContext.
              
              
                cjgillot 2a52436
              
                Generalise QueryJobId.
              
              
                cjgillot a51ad88
              
                Decouple from DepKind.
              
              
                cjgillot 232364a
              
                Generalise QueryLatch.
              
              
                cjgillot 63087b6
              
                Parametrise by try_collect_active_jobs.
              
              
                cjgillot 42f0db5
              
                Move HashStable bound to the trait definition.
              
              
                cjgillot decfd70
              
                Generalise try_get_cached.
              
              
                cjgillot 4ac4ccd
              
                Generalise JobOwner::try_start.
              
              
                cjgillot 27e8a95
              
                Generalise Query starting.
              
              
                cjgillot 6184a71
              
                Make get_query into an extension trait.
              
              
                cjgillot 5b8dac3
              
                Move query system to librustc_query_system.
              
              
                cjgillot 8e873c3
              
                Make librustc_query_system compile.
              
              
                cjgillot dca0344
              
                Make librustc compile.
              
              
                cjgillot 301ad11
              
                Rustfmt.
              
              
                cjgillot d305b2c
              
                Unify key types in get_lookup.
              
              
                cjgillot 228ca8e
              
                Access QueryStateShard directly.
              
              
                cjgillot b6033fc
              
                Retire DepGraphSafe and HashStableContext.
              
              
                cjgillot 0e8b59a
              
                Prune dependencies.
              
              
                cjgillot fa06cfd
              
                Move generics on QueryCache.
              
              
                cjgillot 5dfed41
              
                Simplify generics on try_start.
              
              
                cjgillot fce0d37
              
                Add comment.
              
              
                cjgillot d224e21
              
                Rename read_query_job -> current_query_job and simplify it.
              
              
                cjgillot 260cfab
              
                Don't allow access to the Session.
              
              
                cjgillot 4faf701
              
                Remove the QueryGetter trait.
              
              
                cjgillot db5be1f
              
                Move QueryContext to the parent module.
              
              
                cjgillot 222d010
              
                Cleanups.
              
              
                cjgillot 2d7bbda
              
                Implement HashStable directly.
              
              
                cjgillot File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This trait seems useless now =P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used by the macro
HashStable_GenericforWorkProductId. I can implement it by hand also.