Skip to content

Conversation

petrochenkov
Copy link
Contributor

The second item from #83824 (comment).

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2021
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 6, 2021
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2021
@bors
Copy link
Collaborator

bors commented Jun 6, 2021

⌛ Trying commit e45d869 with merge f980a6509ca6ba43d60fdc29723f7b3c7b8497f1...

@bors
Copy link
Collaborator

bors commented Jun 6, 2021

☀️ Try build successful - checks-actions
Build commit: f980a6509ca6ba43d60fdc29723f7b3c7b8497f1 (f980a6509ca6ba43d60fdc29723f7b3c7b8497f1)

@rust-timer
Copy link
Collaborator

Queued f980a6509ca6ba43d60fdc29723f7b3c7b8497f1 with parent 3740ba2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f980a6509ca6ba43d60fdc29723f7b3c7b8497f1): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 6, 2021
@petrochenkov
Copy link
Contributor Author

Not a regression.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
expand: Move some more derive logic to rustc_builtin_macros

And cleanup some `unwrap`s in `cfg_eval`.

Refactorings extracted from rust-lang#83354 and rust-lang#86057.
r? `@Aaron1011`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
expand: Move some more derive logic to rustc_builtin_macros

And cleanup some `unwrap`s in `cfg_eval`.

Refactorings extracted from rust-lang#83354 and rust-lang#86057.
r? ``@Aaron1011``
@petrochenkov petrochenkov deleted the derivecfglimit branch February 22, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants