Skip to content

simplify validate_generic_param_order #86185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

simplify validate_generic_param_order #86185

merged 1 commit into from
Jun 13, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 9, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2021
klensy
klensy commented Jun 9, 2021
View reviewed changes
klensy
klensy commented Jun 9, 2021
View reviewed changes
@klensy
Copy link
Contributor Author

klensy commented Jun 9, 2021

Will squash after review.

klensy
klensy commented Jun 9, 2021
View reviewed changes
klensy
klensy commented Jun 10, 2021
View reviewed changes
@klensy
Copy link
Contributor Author

klensy commented Jun 10, 2021

Expecting small perf improvement, perf run please?

@petrochenkov
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 10, 2021
@bors
Copy link
Collaborator

bors commented Jun 10, 2021

⌛ Trying commit ce4308e489461c77cea1e37f405673cf7f031c21 with merge 4bc7477fe1c867c78f756dbad76db4ea55c7eebf...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2021
@bors
Copy link
Collaborator

bors commented Jun 10, 2021

☀️ Try build successful - checks-actions
Build commit: 4bc7477fe1c867c78f756dbad76db4ea55c7eebf (4bc7477fe1c867c78f756dbad76db4ea55c7eebf)

@rust-timer
Copy link
Collaborator

Queued 4bc7477fe1c867c78f756dbad76db4ea55c7eebf with parent c5fbcd3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (4bc7477fe1c867c78f756dbad76db4ea55c7eebf): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 10, 2021
@klensy
Copy link
Contributor Author

klensy commented Jun 10, 2021

Nothing interesting in perf, at least not regressed.

@petrochenkov
Copy link
Contributor

r=me with #86185 (comment) and commits squashed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2021
@bors

This comment has been minimized.

Sign in to view
@klensy klensy force-pushed the ast-val branch 3 times, most recently from 39095f2 to f8e3cf7 Compare June 12, 2021 22:32
@klensy
Copy link
Contributor Author

klensy commented Jun 12, 2021

@rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 13, 2021

📌 Commit 6a19867 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2021
@bors
Copy link
Collaborator

bors commented Jun 13, 2021

⌛ Testing commit 6a19867 with merge 6cc5d54...

@bors
Copy link
Collaborator

bors commented Jun 13, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6cc5d54 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2021
@bors bors merged commit 6cc5d54 into rust-lang:master Jun 13, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 13, 2021
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 11, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-const-generics Area: const generics (parameters and arguments) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@klensy @rust-highfive @petrochenkov @rust-timer @bors @lcnr @rustbot