Reenable RemoveZsts #88176
Merged
Reenable RemoveZsts #88176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removezsts, r=oli-obk"" This reverts commit 8e11199.
rust-highfive
added
the
S-waiting-on-review
|
Please add the example from #88043 as a regression test. I know we have a regression test for the unoptimized reproduction, but think we should cover both here. Note that the ui test needs to be |
|
We already have a test for both cases: I added the RemoveZsts-dependent one when I reverted it, and |
|
oh oops, forgot it was added in the revert, thanks! @bors r+ rollup=never |
|
📌 Commit 6ea536d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the underlying issue has been fixed by #88124, we can reland #83417.
r? @oli-obk