Allow specialized const trait impls. #95292

BGR360 · 2022-03-25T00:36:56Z

I've done my best to create a comprehensive test suite for the interaction between min_specialization and const_trait_impls. I wouldn't be surprised if there are interesting cases I haven't tested, please let me know.

rust-highfive · 2022-03-25T00:37:00Z

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

BGR360 · 2022-03-25T00:45:34Z

@rustbot label +A-specialization +A-traits +F-specialization +F-const_trait_impls

EDIT: whoops i thought you could do that for PRs

lcnr · 2022-03-25T07:07:27Z

marking this as blocked this on a general refactoring of const trait impls, see https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Review.3A.20specialized.20const.20trait.20impls/near/276581945

Not sure whether it would be sensible to close this issue for now or only merge the tests with their current behavior and a FIXME.

bors · 2022-06-28T12:50:13Z

☔ The latest upstream changes (presumably #98396) made this pull request unmergeable. Please resolve the merge conflicts.

fee1-dead

Could you please rebase? I believe this should be unblocked now. Thank you for working on this.

compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs

BGR360 · 2022-09-11T20:10:52Z

At long last 🎉

I'll take a stab at it later today. I imagine it will be more involved than just a rebase, right? IIRC there was some sort of major refactor taking place over the last few months. I sort of expected that I would have to re-implement the fix from scratch.

EDIT: oh, after looking at the code on master, looks like PredicateKinds still have a constness. I thought I remember someone saying that that was gonna be reworked. But I'm not complaining!

BGR360 · 2022-09-11T22:52:24Z

@rustbot ready

compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs

src/test/ui/rfc-2632-const-trait-impl/specialization/const-default-non-const-specialized.rs

src/test/ui/rfc-2632-const-trait-impl/specialization/non-const-default-const-specialized.rs

BGR360 · 2022-09-14T03:20:19Z

@rustbot ready

BGR360

@rustbot ready

@lcnr I finally got around to addressing the last bit of feedback you gave here. Please give a look 🙏

compiler/rustc_hir_analysis/src/impl_wf_check/min_specialization.rs

BGR360 · 2022-11-06T06:10:44Z

.../rfc-2632-const-trait-impl/specialization/const-default-bound-non-const-specialized-bound.rs

+// bgr360: I was only able to exercise the code path that raises the
+// "missing ~const qualifier" error by making this base impl non-const, even
+// though that doesn't really make sense to do. As seen below, if the base impl
+// is made const, rustc fails earlier with an overlapping impl failure.


lcnr

some last nits, then r=me

compiler/rustc_hir_analysis/src/impl_wf_check/min_specialization.rs

Fixes rust-lang#95186. Fixes rust-lang#95187.

…resent in base impl.

BGR360 · 2022-11-10T18:57:25Z

@bors r=lcnr

bors · 2022-11-10T18:57:27Z

@BGR360: 🔑 Insufficient privileges: Not in reviewers

BGR360 · 2022-11-10T18:57:54Z

@lcnr I don't have permission for bors

lcnr · 2022-11-11T13:06:20Z

@bors r+ rollup

bors · 2022-11-11T13:06:22Z

📌 Commit 94f67e6 has been approved by lcnr

It is now in the queue for this repository.

…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Allow specialized const trait impls. Fixes rust-lang#95186. Fixes rust-lang#95187. I've done my best to create a comprehensive test suite for the interaction between `min_specialization` and `const_trait_impls`. I wouldn't be surprised if there are interesting cases I haven't tested, please let me know.

…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 25, 2022

rust-highfive assigned lcnr Mar 25, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2022

workingjubilee added A-trait-system Area: Trait system A-specialization Area: Trait impl specialization F-specialization `#![feature(specialization)]` F-const_trait_impl `#![feature(const_trait_impl)]` labels Mar 25, 2022

lcnr added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2022

BGR360 mentioned this pull request Mar 29, 2022

result_tracing: error return tracing in core BGR360/rust#1

Open

fee1-dead self-assigned this Sep 10, 2022

fee1-dead reviewed Sep 10, 2022

View reviewed changes

compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs Outdated Show resolved Hide resolved

compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs Outdated Show resolved Hide resolved

fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 10, 2022

BGR360 force-pushed the const-trait-specialize branch from d912178 to 92cb72b Compare September 11, 2022 22:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2022

lcnr reviewed Sep 12, 2022

View reviewed changes

compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs Outdated Show resolved Hide resolved

src/test/ui/rfc-2632-const-trait-impl/specialization/const-default-non-const-specialized.rs Outdated Show resolved Hide resolved

lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022

BGR360 commented Sep 12, 2022

View reviewed changes

src/test/ui/rfc-2632-const-trait-impl/specialization/non-const-default-const-specialized.rs Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2022

BGR360 force-pushed the const-trait-specialize branch from a2fea02 to f380b39 Compare November 6, 2022 06:08

BGR360 commented Nov 6, 2022

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2022

lcnr reviewed Nov 7, 2022

View reviewed changes

compiler/rustc_hir_analysis/src/impl_wf_check/min_specialization.rs Outdated Show resolved Hide resolved

compiler/rustc_hir_analysis/src/impl_wf_check/min_specialization.rs Outdated Show resolved Hide resolved

BGR360 added 5 commits November 10, 2022 12:37

Allow specialized const trait impls.

5c25d30

Fixes rust-lang#95186. Fixes rust-lang#95187.

Disallow specializing on const impls with non-const impls.

ce03d25

Add #[const_trait] where needed in tests.

d492b9b

Require ~const qualifier on trait bounds in specializing impls if p…

c0ae62e

…resent in base impl.

Apply PR feedback.

fe53cac

BGR360 force-pushed the const-trait-specialize branch from f380b39 to fe53cac Compare November 10, 2022 18:56

This comment has been minimized.

Sign in to view

Oops, bless this test.

94f67e6

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022

Manishearth mentioned this pull request Nov 11, 2022

Rollup of 8 pull requests #104293

Merged

Manishearth mentioned this pull request Nov 11, 2022

Rollup of 10 pull requests #104305

Closed

bors merged commit cd30ccf into rust-lang:master Nov 11, 2022

rustbot added this to the 1.67.0 milestone Nov 11, 2022

Allow specialized const trait impls. #95292

Allow specialized const trait impls. #95292

Uh oh!

Conversation

BGR360 commented Mar 25, 2022

Uh oh!

rust-highfive commented Mar 25, 2022

Uh oh!

BGR360 commented Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr commented Mar 25, 2022

Uh oh!

bors commented Jun 28, 2022

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BGR360 commented Sep 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BGR360 commented Sep 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BGR360 commented Sep 14, 2022

Uh oh!

BGR360 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BGR360 Nov 6, 2022

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BGR360 commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

BGR360 commented Nov 10, 2022

Uh oh!

This comment has been minimized.

lcnr commented Nov 11, 2022

Uh oh!

bors commented Nov 11, 2022

Uh oh!

Uh oh!

BGR360 commented Mar 25, 2022 •

edited

Loading

BGR360 commented Sep 11, 2022 •

edited

Loading