Skip to content

Change deserves_attention algorithm #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Change deserves_attention algorithm #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/src/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,13 @@ pub(crate) fn deserves_attention(
) -> bool {
match (primary.largest_change(), secondary.largest_change()) {
(Some(c), _) if c.magnitude() >= Magnitude::Medium => true,
(_, Some(c)) if c.magnitude() >= Magnitude::Medium => true,
(_, Some(c)) if c.magnitude() >= Magnitude::Large => true,
_ => {
// How we determine whether a group of small changes deserves attention is and always will be arbitrary,
// but this feels good enough for now. We may choose in the future to become more sophisticated about it.
let primary_n = primary.num_changes();
let secondary_n = secondary.num_changes();
(primary_n * 2 + secondary_n) >= 6
(primary_n * 3 + secondary_n) >= 9
}
}
}
Expand Down