Skip to content

Further refactoring of self update logic #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Further refactoring of self update logic #4412

wants to merge 4 commits into from
+95 −102

Conversation

djc
Copy link
Contributor

@djc djc commented Jul 14, 2025

@djc djc requested review from ChrisDenton and rami3l July 14, 2025 09:07
@rami3l
Copy link
Member

rami3l commented Jul 15, 2025

Thanks for this patch! 🙏

The changes you made seemed innocent at first glance. However, the changes in the order of execution made me a little concerned, which is later confirmed by the test failures... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton Awaiting requested review from ChrisDenton

@rami3l rami3l Awaiting requested review from rami3l

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @rami3l