fix(process): Ensure stdout/stderr lock is held across calls #4514
+54
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `std::io::Write` only has a few required methods, while implementing `anstream` I found its better to implement as many as possible when dealing with `stdout` or `stderr` so that the implicitly acquired lock is aquired once for the call, rather than multiple times as the inherent methods break down a single higher level calls into multiple lower level calls.
djc
approved these changes
Oct 3, 2025
| } | ||
| } | ||
|
|
||
| impl TerminalInner { |
There was a problem hiding this comment.
Nit: ordering in this module is a bit of a mess, but please keep impls directly below their respective type's definitions.
There was a problem hiding this comment.
Was trying to be consistent with the file which seemed to be types before impls (mostly). But fine with changing this.
There was a problem hiding this comment.
Yes, I think that would be nice. I'll clean up the other items after this is merged.
(Note that CI is failing on a formatting issue.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
std::io::Writeonly has a few required methods,while implementing
anstreamI found its better to implementas many as possible when dealing with
stdoutorstderrso that the implicitly acquired lock is aquired once for the call,
rather than multiple times as the inherent methods break down a single higher
level calls into multiple lower level calls.
This is likely not a problem right now but the different layers of APIs, especially in interacting with
tracing, could hit problems with this in the future.