Skip to content

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Oct 4, 2025

Closes #4337 by addressing #4337 (comment):

[..] since this ship has sailed, I've focused my previous comments on the question of whether we should revert this or not. Also, we probably should retroactively add this to the release notes.

Further analysis indicated that the reuse of pre-existing logic has reduced inconsistencies (cfg.get_profile()? instead of Profile::default() in profile.unwrap_or_default()) in that particular issue, even if it means different behaviors being exposed compared to v1.28.1.

@rami3l rami3l requested review from djc and ChrisDenton October 4, 2025 14:18
@rami3l rami3l added this pull request to the merge queue Oct 5, 2025
Merged via the queue into rust-lang:main with commit 1837fa5 Oct 5, 2025
29 checks passed
@rami3l rami3l deleted the docs/changelog-default-profile-change branch October 5, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustup 1.28.2 uses a different default profile during automatic installation
2 participants