Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Oct 24, 2025

With rustup checks colors being testable (#4561), this updates it to match Cargo's colors

@epage epage mentioned this pull request Oct 24, 2025
@epage
Copy link
Contributor Author

epage commented Oct 24, 2025

Looks like a hang in the build and CI needs to be re-kicked off

epage added 2 commits October 24, 2025 11:17
With `rustup check`s colors being testable (rust-lang#4561),
this updates it to match Cargo's colors
@epage epage force-pushed the check branch 2 times, most recently from 9ebdb25 to e8f5d9d Compare October 24, 2025 16:21
@epage
Copy link
Contributor Author

epage commented Oct 24, 2025

Now a test failure that I can't reproduce


thread 'download::tests::reqwest::socks_proxy_request' panicked at src/download/tests.rs:179:13:
assertion `left == right` failed
  left: 0
 right: 1

} else {
Style::new()
};
let transient = if use_colors { TRANSIENT } else { Style::new() };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest doing it more like this:

let (transient, error, good, warn) = match use_colors {
     true => (TRANSIENT, ERROR, GOOD, WARN),
     false => (Style::new(), Style::new(), Style::new(), Style::new()),
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants