Fix refresh rate for progress bars #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
approved these changes
Nov 18, 2025
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
The code looks pretty simple. I entrust you with the manual testing of the fix :)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it seemed like a good idea at the time to avoid applying a rate limit to progress bar drawing to a
TermLike, since a consumer might want to be able to observe every draw. In this case, though, we really want some rate limiting to prevent flickering, so explicitly set the refresh rate to indicatif's default of 20 Hz.