ensure callers of BuildDirectory::run can determine if the source of the error is in Prepare::prepare
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
added a commit
to Skgland/crater
that referenced
this pull request
Jul 22, 2025
Skgland
added a commit
to Skgland/crater
that referenced
this pull request
Jul 22, 2025
|
Making it a draft while I add tests (rebasing on top of the first two commit of #98) |
if a more specifc one hasn't already been provided this way we can easily distinguish BuildDirectory::run failing due to Prepare::prepare failing from it failing for other reasons
Skgland
force-pushed
the
ensure_prepare_error_context
branch
from
8bd1691 to
f25d523
Compare
to discourage explicitly matching this variant explicitly. As the enum is non_exhaustive a wildcard pattern is required anyway.
to match std::io::ErrorKind::Uncategorized
|
Renamed the added |
|
@syphar ping for review, as it has been two weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this can be difficult to distinguish whether
BuildDirectory::runfailed due toffailing or due toPrepare::preparefailing.Related to #98 as it helps with errors not easily sub-categorized to at least get them into the general category of prepare failures.