Skip to content

loongarch: Mark partial intrinsics as safe #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jul 15, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, I added some nits and questions inline

@heiher heiher force-pushed the loong-safe branch 2 times, most recently from b74c6da to a239250 Compare July 18, 2025 04:12
@folkertdev folkertdev added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@folkertdev
Copy link
Contributor

the generated version of the file is not the same as the checked-in version (just some whitespace). Can you re-run locally and add the updated file?

@heiher
Copy link
Contributor Author

heiher commented Jul 18, 2025

the generated version of the file is not the same as the checked-in version (just some whitespace). Can you re-run locally and add the updated file?

Fixed. The generated code no longer needs to be reformatted. (https://github.com/rust-lang/stdarch/pull/1874/files#diff-1f7c8be4f6ea74d070d6b6b9201605541a6c52f74f7fa3c78c83c892b3d5dd7aL14)

@folkertdev folkertdev enabled auto-merge July 18, 2025 12:45
@folkertdev folkertdev added this pull request to the merge queue Jul 18, 2025
Merged via the queue into rust-lang:master with commit 9bbabf3 Jul 18, 2025
63 checks passed
@heiher heiher deleted the loong-safe branch July 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants